Repository navigation
Test that a None install tag does not suppress the installation ID - #44
Merged
Merged
Conversation
report() drops None-valued tags before adding install, so an event passing install=None still carries the client's ID, as one passing version=None still carries the program version. Nothing guarded that order: merging install before dropping None tags would silently send no install tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (CI anchor green on a2fce70: test (3.8), test (3.10), test (3.12) all pass):
Observation outside the diff: the test pins current behavior only. The open question in #16 ( This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B (unit-test expansion) cycle: one characterization test for how an event's own
installtag interacts with the client's installation ID.report()runs_with_version(which dropsNone-valued tags and stringifies the rest) before_with_install. As a result, an event passingtags={"install": None}still carries the client's ID, the same way{"version": None}still carries the program version (already covered bytest_report_drops_none_tags_and_stringifies_the_rest_before_adding_the_version).install. If the two merges were swapped,installwould be seen as present, no ID would be added, and theNonewould then be dropped, so the event would carry noinstalltag and no test would fail. That breaks the README promise thattagsholdsinstallwhenever the client has an ID.Nonevalue of another type (7) is the event's own tag, sent as"7", and wins over the client's ID.No production code is changed, and no Java-visible behavior changed.
Skipped issues
MAX_TAGS/ "always holdsversion" promise and a matching change in trace-client-java.Test plan
python3 -m unittestlocally:Ran 80 tests,OKreport()temporarily swapped, the new test failed ({'version': '1.2.3'}sent, noinstall). With the source restored, it passed.test (3.8),test (3.10),test (3.12)greenNo tracking issue. The gap was found during the Stage B coverage comparison.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson